httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cliff Woolley <>
Subject Re: [PATCH]: emulate_sendfile fix [WAS]: File buckets v. core_output_filter
Date Tue, 23 Mar 2004 09:26:31 GMT
On Tue, 23 Mar 2004, Bojan Smojver wrote:

> Are you referring here to apr_file_seek() (which is done in
> emulate_sendfile() anyway) or to tracking the file position outside?

I'm saying that file_bucket_read() does an apr_file_seek()
unconditionally, because when we tried to have it remember what the
position was and bypass the seek if the position matched, file buckets
were broken whenever the apr_file_t was dup'ed.  Same problem here.

View raw message