httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cliff Woolley <>
Subject Re: [PATCH]: emulate_sendfile fix [WAS]: File buckets v. core_output_filter
Date Mon, 22 Mar 2004 20:55:54 GMT
On Mon, 22 Mar 2004, Bill Stoddard wrote:

> I took a 15 second look at the patch and have a concern (perhaps
> unfounded).  apr_file_seek() is probably an expensive operation. If
> offset is 0, then in almost all cases (correct me if i'm wrong) the
> fileptr will be at offset 0 as well, right? So your patch will result in
> an expensive operation which is not needed most of the time. Is there a
> different way to fix this?

I'll just point out that file_bucket_read() in apr-util does an
unconditional apr_file_seek in the non-mmap case as well.  I'm not aware
of any way around having to do the seek.


View raw message