httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@attglobal.net>
Subject Re: [PATCH] 1.3.29 MPE port update, piped logs, and strdup
Date Wed, 17 Mar 2004 01:30:14 GMT
Bixby, Mark (TCSD-MISL-Cupertino) wrote:
> Hi dev@httpd.apache.org,
> 
> I'd like to get some MPE-related tweaks into the coming 1.3.30.  
 >Can somebody with patch commit authority please ack me if these are OK?
> 
> 1) New MPE-specific platform doc web page (in attachment but omitted below).

no comment yet

> 2) The piped logs process was never terminating on MPE because the
 > pipe wasn't being closed after the maintenance restart SIGTERM
 >signal was sent.  My patch closes the pipe here (note -- I did
 >not make this MPE-specific since another SIGTERM case does
 >close the pipe for all platforms).  See below or in the attachment.

can you describe the scenario?  surely there are some close() calls that will 
now fail (or close the wrong thing) on non-MPE?

> 3) MPE lacks ftruncate() as expected by rotatelogs, 

no comment here; I'd rather avoid thinking about the copyright issue ;)


> 4) MPE lacks strdup(), and so ab's use of strdup() was a problem.  I 
>have added strdup() to ab similar to what was done in
 > logresolve (i.e. #ifdef NEED_STRDUP).  See below or in the attachment.

+1 for ab change


Mime
View raw message