httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From André Malo ...@perlig.de>
Subject Re: [PATCH] RewriteCond and SSL environment variables
Date Thu, 04 Mar 2004 10:08:25 GMT
* Joe Orton <jorton@redhat.com> wrote:

> I'm not really convinced about using ssl_var_lookup_ssl: that function
> does not handle the "HTTPS" variable, and it would be potentially
> confusing to users and hard to document since only some subset of the
> SSL variables could be used.  (it would also need a new optional
> function in mod_ssl)
> 
> I'll commit the original patch with Madhu's fix to check
> rewrite_ssl_lookup unless there are any strong objections.

Then it's time to change it. The ssl_var_lookup function is totally messy
and _slow_.
We want SSL variables, so let's only grab them.

I'm -1 (vote not veto) on using the generic ssl_var_lookup function. Maybe
we should put the HTTPS check into an own function (we could use %{HTTPS} in
mod_rewrite then). That way, other modules, that want to check (only) HTTPS,
also don't need to run though all the mess of ssl_var_lookup.

nd

Mime
View raw message