httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: [PATCH] SSLCryptoDevCtl support
Date Thu, 19 Feb 2004 16:04:51 GMT
On Thu, Feb 19, 2004 at 09:41:55AM -0600, Serge Hallyn wrote:
...
> +
> +/* Our static variables get reset between first and second pass ... so this
> + * variable is mixed in key-value strings and incremented. On the second pass,
> + * the key-values will match so will replace, rather than supplement, the table
> + * entries. (All this to prevent getting two copies of everything?!) */
> +static int braindead = 0;

I think that stuff be avoided by using the:

    if (ssl_config_global_isfixed(mc)) {
        return NULL;
    }

trick like the other ssl_cmd_* functions?  There are code formatting
issues through the rest of the patch, otherwise looks OK - a patch
against HEAD would be ideal of course...

> +const char *ssl_cmd_SSLCryptoDeviceCtrl(cmd_parms *cmd,
> +					void *dcfg,
> +					const char *arg,
> +					const char *prepost)
> +{
...
> +    colon = strchr(arg, ':');

should be ap_strchr_c() to avoid losing const-ness.

> +static int internal_ctrl_cb(void *r, const char *k, const char *v)

could do with some meaningful parameter names :)

Regards,

joe

Mime
View raw message