httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: [PATCH] new finish_connection hook & SSL closure fix
Date Sun, 08 Feb 2004 19:56:50 GMT
On Sun, Feb 08, 2004 at 11:08:37AM -0800, Justin Erenkrantz wrote:
> --On Sunday, February 8, 2004 5:27 PM +0000 Joe Orton <jorton@redhat.com> 
> wrote:
> 
> >This adds a finish_connection hook as discussed with Madhu, and uses it
> >in mod_ssl to ensure that the SSL close_notify alert is sent before the
> >connection is closed. Any comments?
> 
> Would an EOS sent to the output connection-level filters before a close is 
> issued be sufficient?  Could we change ap_flush_conn to also pass down an 
> EOS after the flush?  Or, if an EOS can be sent otherwise (I forget if it 
> is), could we just create a generic EOC bucket to pass in ap_flush_conn?

The mod_ssl output filter already gets an EOS after every request on the
connection currently.  Doing a generic EOC bucket sounds good.

> That should serve the same purpose, I think, without the hook.  -- justin

Makes sense also since any other SSL-like connection filter might well
need similar shutdown logic.  I'll have a go at this - thanks Justin!

joe

Mime
View raw message