httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Serge Hallyn <se...@us.ibm.com>
Subject Re: [PATCH] SSLCryptoDevCtl support
Date Mon, 23 Feb 2004 20:02:33 GMT
Hi,

thanks for your reply.  Attached is a new patch against HEAD taking your
comments into consideration.

Note that the static int firsttime hack can go away as soon as the
repeated config reads in main() are consolidated.

thanks,
-serge

On Thu, 2004-02-19 at 10:04, Joe Orton wrote:
...
> I think that stuff be avoided by using the:
> 
>     if (ssl_config_global_isfixed(mc)) {
>         return NULL;
>     }
> 
> trick like the other ssl_cmd_* functions?  There are code formatting
> issues through the rest of the patch, otherwise looks OK - a patch
> against HEAD would be ideal of course...
> 
> > +const char *ssl_cmd_SSLCryptoDeviceCtrl(cmd_parms *cmd,
> > +					void *dcfg,
> > +					const char *arg,
> > +					const char *prepost)
> > +{
> ...
> > +    colon = strchr(arg, ':');
> 
> should be ap_strchr_c() to avoid losing const-ness.
> 
> > +static int internal_ctrl_cb(void *r, const char *k, const char *v)
> 
> could do with some meaningful parameter names :)
> 
> Regards,
> 
> joe
-- 
=======================================================
Serge Hallyn
Security Software Engineer, IBM Linux Technology Center
serue@us.ibm.com

Mime
View raw message