Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 37974 invoked from network); 9 Jan 2004 14:16:04 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 9 Jan 2004 14:16:04 -0000 Received: (qmail 70979 invoked by uid 500); 9 Jan 2004 14:15:56 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 70730 invoked by uid 500); 9 Jan 2004 14:15:54 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 70716 invoked from network); 9 Jan 2004 14:15:54 -0000 Received: from unknown (HELO secure.exclamationlabs.net) (66.77.29.186) by daedalus.apache.org with SMTP; 9 Jan 2004 14:15:54 -0000 Received: from modperlcookbook.org (pcp05675728pcs.walngs01.pa.comcast.net [69.139.161.218]) (authenticated (0 bits)) by secure.exclamationlabs.net (8.11.6/8.11.6) with ESMTP id i09EFtu06306 for ; Fri, 9 Jan 2004 08:15:55 -0600 Message-ID: <3FFEB793.4050808@modperlcookbook.org> Date: Fri, 09 Jan 2004 09:15:47 -0500 From: Geoffrey Young User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20030225 X-Accept-Language: en-us, en MIME-Version: 1.0 To: dev@httpd.apache.org Subject: Re: log_error_core escaping change broke things References: <3FE2B378.1030908@stason.org> <20031219102709.4ea48726.nd@perlig.de> <3FE2CE0A.2080909@stason.org> <20031219130404.00002a37.nd@perlig.de> <20031219130404.00002a37.nd@perlig.de> <3FE35130.50106@stason.org> <200312211525.hBLFPBY10807@secure.exclamationlabs.net> <3FFC6C58.9070307@modperlcookbook.org> <3FFDC1A8.3060409@stason.org> <20040109102919.00002e32.nd@perlig.de> In-Reply-To: <20040109102919.00002e32.nd@perlig.de> X-Enigmail-Version: 0.71.0.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Andr� Malo wrote: > * Stas Bekman wrote: > > >>Though since it really affects any logging it probably should be called >>UNESCAPED_LOGGING or similar. And probably a similar patch applied to 1.3. > > > It only affects error logging. that was my intent. > What do you mean by any logging? > > I can live with it in general (wouldn't make the scratch definition twice). sorry, that was me trying to make it compile under -Werror with my only passable C skills :) > However, is it wise to add a configure option for it? how do you mean? I was trying to make it just a compile time option, similar to -DBIG_SECURITY_HOLE (which seems to me a bigger risk than this). do you mean to require users to change a define in the code itself? --Geoff