httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brad Nicholes" <>
Subject Re: cvs commit: httpd-2.0/modules/loggers mod_log_forensic.c
Date Sat, 03 Jan 2004 19:36:41 GMT
   Since the test_char.h header file is not located in the same place on
the NetWare build as it is for Linux, the path can not be hardcoded. 
This may break the build of mod_log_forensic on Linux until the path is
added to the INCLUDE path.  Since I am not sure where this should be
added on Linux, could somebody that knows more about the Linux makefiles
than I do, make this change?


Brad Nicholes
Senior Software Engineer
Novell, Inc., the leading provider of Net business solutions 

>>> Saturday, January 03, 2004 12:18:54 PM >>>
bnicholes    2004/01/03 11:18:53

  Modified:    modules/loggers mod_log_forensic.c
  Don't hardcode the location of the test_char.h header.  The path
should be added to the INCLUDE path.  Also, use the apr_uint32_t type
for next_id which is compatible with the apr_atomic functions.
  Revision  Changes    Path
  1.7       +2 -2      httpd-2.0/modules/loggers/mod_log_forensic.c
  Index: mod_log_forensic.c
  RCS file: /home/cvs/httpd-2.0/modules/loggers/mod_log_forensic.c,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- mod_log_forensic.c	3 Jan 2004 16:02:15 -0000	1.6
  +++ mod_log_forensic.c	3 Jan 2004 19:18:53 -0000	1.7
  @@ -75,7 +75,7 @@
   #include "apr_atomic.h"
   #include <unistd.h>
   #include "http_protocol.h"
  -#include "../../server/test_char.h"
  +#include "test_char.h"
   module AP_MODULE_DECLARE_DATA log_forensic_module;
  @@ -84,7 +84,7 @@
       apr_file_t *fd;
   } fcfg;
  -static int next_id;
  +static apr_uint32_t next_id;
   static void *make_forensic_log_scfg(apr_pool_t *p, server_rec *s)

View raw message