httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bill Stoddard <b...@wstoddard.com>
Subject Re: cvs commit: httpd-2.0/modules/experimental mod_mem_cache.c
Date Fri, 09 Jan 2004 02:48:26 GMT
Jean-Jacques Clar wrote:
> Bill,
>  
> The patch you committed is only for 21285.
>  
> My bet for 21287 (no mutex lock protection in decrement_refcount).
> from the bug description:
> "/There are no mutex lock protection in decrement_refcount if it is
> defined USE_ATOMICS.
> 
> I think you simply forgot the mutex in function decrement_refcount.
> There is a race condition in the cleanup_cache_object when two threads
> are trying to clean-up the same object which is no longer referenced in 
> the cache./"
> The changes were done to protect calls to cleanup_cache_object() w/o
> a lock protection, but you are right the atomic inc/dec on refcount
> seems to do it safely.
>  
> Looks like 21287 it is not a valid defect based on your explanation.
> How do I rev back my changes?

Here is how you can see the patch:

cvs diff -u -r 1.102 -r 1.103 mod_mem_cache.c

revison numbers are from cvs.apache.org.

Verify the diff above and if it is the one you want to revert, I believe you can roll it back
thusly:

cvs update -j 1.103 -j 1.102 mod_mem_cache.c

Bill


Mime
View raw message