Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 88612 invoked from network); 3 Dec 2003 14:24:21 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 3 Dec 2003 14:24:21 -0000 Received: (qmail 64754 invoked by uid 500); 3 Dec 2003 14:24:01 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 64499 invoked by uid 500); 3 Dec 2003 14:23:59 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 64486 invoked from network); 3 Dec 2003 14:23:59 -0000 Received: from unknown (HELO Boron.MeepZor.Com) (204.146.167.214) by daedalus.apache.org with SMTP; 3 Dec 2003 14:23:59 -0000 Received: from wstoddard.com (dmz-firewall [206.199.198.4]) by Boron.MeepZor.Com (8.11.6/8.11.6) with ESMTP id hB3EO1p24074 for ; Wed, 3 Dec 2003 09:24:01 -0500 Message-ID: <3FCDF1DC.7060502@wstoddard.com> Date: Wed, 03 Dec 2003 09:23:24 -0500 From: Bill Stoddard User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4) Gecko/20030624 X-Accept-Language: en-us, en MIME-Version: 1.0 To: dev@httpd.apache.org Subject: Re: cvs commit: httpd-2.0/server/mpm/winnt child.c mpm.h References: <20031120194419.88528.qmail@minotaur.apache.org> In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Cliff Woolley wrote: > On Thu, 20 Nov 2003 stoddard@apache.org wrote: > > >>stoddard 2003/11/20 11:44:19 >> >> Modified: . CHANGES >> server/mpm/winnt child.c mpm.h >> Log: >> Win32: Make Win32 MPM transaction pools honor MaxMemFree >> >> /* Create the tranaction pool */ >> - if ((rv = apr_pool_create(&context->ptrans, pchild)) != APR_SUCCESS) { >> + apr_allocator_create(&allocator); >> + apr_allocator_max_free_set(allocator, ap_max_mem_free); >> + rv = apr_pool_create_ex(&context->ptrans, NULL, NULL, allocator); >> + if (rv != APR_SUCCESS) { >> ap_log_error(APLOG_MARK,APLOG_WARNING, rv, ap_server_conf, >> "mpm_get_completion_context: Failed to create the transaction pool."); >> CloseHandle(context->Overlapped.hEvent); >> return NULL; >> } >> - apr_pool_tag(context->ptrans, "ptrans"); >> + apr_allocator_owner_set(allocator, context->ptrans); >> + apr_pool_tag(context->ptrans, "transaction"); > > > This seems reasonable. +1 (untested). One question, though. Why is > ptrans no longer a child pool of pchild? > > --Cliff > Good intentions and all I was going to look into that. This was a straight port from worker. Bill