Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 2484 invoked from network); 10 Dec 2003 15:05:28 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 10 Dec 2003 15:05:28 -0000 Received: (qmail 44531 invoked by uid 500); 10 Dec 2003 15:05:19 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 44442 invoked by uid 500); 10 Dec 2003 15:05:18 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 44429 invoked from network); 10 Dec 2003 15:05:18 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by daedalus.apache.org with SMTP; 10 Dec 2003 15:05:18 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id hBAF5K204867 for ; Wed, 10 Dec 2003 10:05:20 -0500 Received: from radish.cambridge.redhat.com (radish.cambridge.redhat.com [172.16.18.90]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id hBAF5J229133 for ; Wed, 10 Dec 2003 10:05:19 -0500 Received: from radish.cambridge.redhat.com (localhost.localdomain [127.0.0.1]) by radish.cambridge.redhat.com (8.12.10/8.12.7) with ESMTP id hBAF5F3i015307 for ; Wed, 10 Dec 2003 15:05:15 GMT Received: (from jorton@localhost) by radish.cambridge.redhat.com (8.12.10/8.12.10/Submit) id hBAF5C8W015306 for dev@httpd.apache.org; Wed, 10 Dec 2003 15:05:12 GMT Date: Wed, 10 Dec 2003 15:05:12 +0000 From: Joe Orton To: dev@httpd.apache.org Subject: Re: cvs commit: httpd-2.0/server main.c Message-ID: <20031210150512.GB17180@redhat.com> Mail-Followup-To: dev@httpd.apache.org References: <20031210134314.42968.qmail@minotaur.apache.org> <3FD72CA6.2080200@attglobal.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3FD72CA6.2080200@attglobal.net> User-Agent: Mutt/1.4.1i X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N On Wed, Dec 10, 2003 at 09:24:38AM -0500, Jeff Trawick wrote: > jorton@apache.org wrote: > > >jorton 2003/12/10 05:43:14 > > > > Modified: server main.c > > Log: > > * server/main.c (suck_in_expat): Remove function, USE_EXPAT is never > > defined. > > Does anyone have clues about the other hacks at the end of main.c? > > Isn't the #ifdef AP_USING_AUTOCONF hack useful only if apr/apr-util is > statically linked with httpd? (Not possible with current build system > AFAIK.) suck_in_APR() is necessary to pull in all of libmain.la and libos.la regardless of static/shared apr. (--disable-shared still gives you apr statically linked into httpd, yes) > What about #ifndef SHARED_CORE_BOOTSTRAP? I don't know about the symbol > name, but the comment Yes, I think suck_in_apr_password_validate can too, ap_hack_apr_password_validate should do the same job.