httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brad Nicholes" <BNICHO...@novell.com>
Subject Re: cvs commit: httpd-2.0/modules/experimental mod_charset_lite.c
Date Mon, 15 Dec 2003 16:31:31 GMT
-1 Please use some other #define.  This won't build with Metrowerks on
NetWare.

Brad

Brad Nicholes
Senior Software Engineer
Novell, Inc., the leading provider of Net business solutions
http://www.novell.com 

>>> jorton@redhat.com Monday, December 15, 2003 8:18:05 AM >>>
On Mon, Dec 15, 2003 at 02:24:31PM -0000, martin@apache.org wrote:
...
>   diff -u -u -r1.66 -r1.67
>   --- mod_charset_lite.c	7 Nov 2003 01:01:27 -0000	1.66
>   +++ mod_charset_lite.c	15 Dec 2003 14:24:31 -0000	1.67
>   @@ -307,7 +307,16 @@
>                              "mime type is %s; no translation
selected",
>                              mime_type);
>            }
>   +#if #system(bs2000)

"#system(bs2000)" looks pretty risky as a preprocessor symbol, is
there
nothing else you can use here?

Mime
View raw message