httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cliff Woolley <jwool...@virginia.edu>
Subject RE: Mem Leak when reverse proxying HTTP post requests
Date Tue, 09 Dec 2003 21:37:01 GMT
On Tue, 9 Dec 2003, Larry Toppi wrote:

> I found the culprit.  The EOS bucket was being removed from the brigade but
> not destroyed.  I'm going to submit the following patch to fix this bug.
>
> *** proxy_http_old.c Tue Dec  9 16:19:52 2003
> --- proxy_http.c Tue Dec  9 16:22:14 2003
> ***************
> *** 665,671 ****
>               }
>
>               /* We can't pass this EOS to the output_filters. */
> !             APR_BUCKET_REMOVE(APR_BRIGADE_LAST(bb));
>               seen_eos = 1;
>           }
>
> --- 665,672 ----
>               }
>
>               /* We can't pass this EOS to the output_filters. */
> !             e = APR_BRIGADE_LAST(bb);
> !             apr_bucket_delete(e);
>               seen_eos = 1;
>           }

That looks like a bug to me, yes... though I haven't checked the
broader context in detail yet to verify.

--Cliff

Mime
View raw message