httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: cvs commit: httpd-2.0 CHANGES
Date Tue, 09 Dec 2003 22:47:18 GMT
William A. Rowe, Jr. wrote:
> At 12:37 PM 12/9/2003, Stas Bekman wrote:
> 
> 
>>Does this look good?
>>
>>        ap_log_rerror(APLOG_MARK, APLOG_WARNING, 0, r,
>>                      "mod_include: Options +Includes (or IncludesNoExec) "
>>-                      "wasn't set, passing data unmodified");
>>+                      "wasn't set, passing data unmodified, removing myself");
>>+        ap_remove_output_filter(f);
> 
> 
> Admins have to read this message in their logs, not coders.  What about this:

Sure

>>mod_include: Options +Includes (or IncludesNoExec) wasn't set, include filter removed
                                                                  ^^^^^^^
Here is an adjusted patch, I've s/include/INCLUDES/ in your suggestion.

Index: modules/filters/mod_include.c
===================================================================
RCS file: /home/cvs/httpd-2.0/modules/filters/mod_include.c,v
retrieving revision 1.291
diff -u -r1.291 mod_include.c
--- modules/filters/mod_include.c       9 Dec 2003 01:58:21 -0000       1.291
+++ modules/filters/mod_include.c       9 Dec 2003 22:39:32 -0000
@@ -3603,7 +3603,8 @@
      if (!(ap_allow_options(r) & OPT_INCLUDES)) {
          ap_log_rerror(APLOG_MARK, APLOG_WARNING, 0, r,
                        "mod_include: Options +Includes (or IncludesNoExec) "
-                      "wasn't set, passing data unmodified");
+                      "wasn't set, INCLUDES filter removed");
+        ap_remove_output_filter(f);
          return ap_pass_brigade(f->next, b);
      }


__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


Mime
View raw message