httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: cvs commit: httpd-2.0 CHANGES
Date Tue, 09 Dec 2003 18:37:21 GMT
Stas Bekman wrote:
> Jeff Trawick wrote:
[...]
>>> &include_module);
>>>           if (!(ap_allow_options(r) & OPT_INCLUDES)) {
>>>   +        ap_log_rerror(APLOG_MARK, APLOG_WARNING, 0, r,
>>>   +                      "mod_include: Options +Includes (or 
>>> IncludesNoExec) "
>>>   +                      "wasn't set, passing data unmodified");
>>>            return ap_pass_brigade(f->next, b);
>>>        }
>>
>>
>>
>> I like very much, but shouldn't mod_include remove itself from the 
>> filter list here to avoid seeing the same warning multiple times for 
>> certain types of objects?
>>
>> ap_remove_output_filter(f);
>>
>> (That should have been there all along I think.)
> 
> 
> Well, if you've misconfigured your server you better fix it and not put 
> it in production with even a single warning. So may be it's for the best 
> that it will be annoyingly noisy ;)
> 
> But I'm certainly +1 to remove itself.

Does this look good?

Index: modules/filters/mod_include.c
===================================================================
RCS file: /home/cvs/httpd-2.0/modules/filters/mod_include.c,v
retrieving revision 1.291
diff -u -r1.291 mod_include.c
--- modules/filters/mod_include.c       9 Dec 2003 01:58:21 -0000       1.291
+++ modules/filters/mod_include.c       9 Dec 2003 18:30:22 -0000
@@ -3603,7 +3603,8 @@
      if (!(ap_allow_options(r) & OPT_INCLUDES)) {
          ap_log_rerror(APLOG_MARK, APLOG_WARNING, 0, r,
                        "mod_include: Options +Includes (or IncludesNoExec) "
-                      "wasn't set, passing data unmodified");
+                      "wasn't set, passing data unmodified, removing myself");
+        ap_remove_output_filter(f);
          return ap_pass_brigade(f->next, b);
      }



__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


Mime
View raw message