httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@attglobal.net>
Subject Re: cvs commit: httpd-2.0 CHANGES
Date Tue, 09 Dec 2003 10:38:25 GMT
stas@apache.org wrote:

>        complain via error_log when mod_include's INCLUDES filter is
>        enabled, but the relevant Options flag allowing the filter to run
>        for the specific resource wasn't set, so that the filter won't
>        silently get skipped.

>   Index: mod_include.c
>   ===================================================================
>   RCS file: /home/cvs/httpd-2.0/modules/filters/mod_include.c,v
>   retrieving revision 1.290
>   retrieving revision 1.291
>   diff -u -u -r1.290 -r1.291
>   --- mod_include.c	2 Nov 2003 22:09:19 -0000	1.290
>   +++ mod_include.c	9 Dec 2003 01:58:21 -0000	1.291
>   @@ -3601,6 +3601,9 @@
>                                                           &include_module);
>    
>        if (!(ap_allow_options(r) & OPT_INCLUDES)) {
>   +        ap_log_rerror(APLOG_MARK, APLOG_WARNING, 0, r,
>   +                      "mod_include: Options +Includes (or IncludesNoExec) "
>   +                      "wasn't set, passing data unmodified");
>            return ap_pass_brigade(f->next, b);
>        }

I like very much, but shouldn't mod_include remove itself from the filter list 
here to avoid seeing the same warning multiple times for certain types of objects?

ap_remove_output_filter(f);

(That should have been there all along I think.)



Mime
View raw message