httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Geoffrey Young <ge...@modperlcookbook.org>
Subject [PATCH] catching malformed container directives
Date Mon, 08 Dec 2003 16:00:14 GMT
hi all...

currently, all core container directives have an issue (albeit a minor one)
- they require an argument in practice but are allowed to proceed without
one during configuration.

for example

<IfModule >

does not currently throw an error.  instead, the config is allowed to
proceed, soaking up the container.

while the subsequent behavior seems ok, to me the lack of feedback for a
malformed directive is less than ideal, especially if users are using a
template to configure apache - something like this

<IfModule [% mymod %]>

or whatever would silently proceed if the substitution variable was
unpopulated, which is a tricky thing to track down

anyway, attached is a patch that makes <IfModule>, <IfDefine>, <Directory>,
<Location>, <Files> (and their regex counterparts), <Limit>, <LimitExcept>,
and <VirtualHost> containers fail if no arguments are specified.

--Geoff

Mime
View raw message