httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From André Malo ...@perlig.de>
Subject Re: cvs commit: apache-1.3/src/main http_log.c util.c
Date Mon, 15 Dec 2003 15:05:18 GMT
* Ben Laurie <ben@algroup.co.uk> wrote:

> >   -    char errstr[MAX_STRING_LEN];
> >   +    char errstr[MAX_STRING_LEN], scratch[MAX_STRING_LEN];
> 
> Surely scratch and errstr should be MAX_STRING_LEN*4?

Hmm. MAX_STRING_LEN is 8k. So we put 16k onto the stack now. Would you
really like to mess up the stack with 64KB for error message stuff? At least
on threaded platforms this will fail.

> >   +                c2x(*s, d);
> 
> Am I being dim? Shouldn't this be c2x(*s,d+1)?

ehm, no?

nd

Mime
View raw message