Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 35574 invoked from network); 26 Nov 2003 09:39:18 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 26 Nov 2003 09:39:18 -0000 Received: (qmail 45574 invoked by uid 500); 26 Nov 2003 09:38:50 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 45261 invoked by uid 500); 26 Nov 2003 09:38:48 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 45244 invoked from network); 26 Nov 2003 09:38:47 -0000 Received: from unknown (HELO scuzzy.ben.algroup.co.uk) (217.155.92.105) by daedalus.apache.org with SMTP; 26 Nov 2003 09:38:47 -0000 Received: from algroup.co.uk (wiese.ben.algroup.co.uk [193.133.15.150]) by scuzzy.ben.algroup.co.uk (Postfix) with ESMTP id 31B828B8A6 for ; Wed, 26 Nov 2003 09:38:58 +0000 (GMT) Message-ID: <3FC474AD.3000302@algroup.co.uk> Date: Wed, 26 Nov 2003 09:38:53 +0000 From: Ben Laurie User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-GB; rv:1.4; MultiZilla v1.5.0.2g) Gecko/20031007 MultiZilla/1.5.0.4e X-Accept-Language: en-us, en MIME-Version: 1.0 To: dev@httpd.apache.org Subject: Re: [PACTH] sdbm.c, silent warning messages on gcc 2.95.3 with debug References: <3F0B4F12.2060703@cultura.com.br> <3FBABC5D.1080702@attglobal.net> In-Reply-To: <3FBABC5D.1080702@attglobal.net> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Jeff Trawick wrote: > ranier wrote: > >> --- sdbm-old.c 2003-07-08 19:55:04.000000000 -0300 >> +++ sdbm.c 2003-07-08 19:57:52.000000000 -0300 >> @@ -495,7 +495,7 @@ >> while (dbit < db->maxbno && getdbit(db, dbit)) >> dbit = 2 * dbit + ((hash & (1 << hbit++)) ? 2 : 1); >> >> - debug(("dbit: %d...", dbit)); >> + debug(("dbit: %lu...", dbit)); > > > shouldn't your changes use %ld instead of %lu? It looks to me that dbit > and pagb are longs, not unsigned longs. Surely at least dbit should be unsigned? Cheers, Ben. -- http://www.apache-ssl.org/ben.html http://www.thebunker.net/ "There is no limit to what a man can do or how far he can go if he doesn't mind who gets the credit." - Robert Woodruff