Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 84180 invoked from network); 20 Nov 2003 02:50:46 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 20 Nov 2003 02:50:46 -0000 Received: (qmail 44735 invoked by uid 500); 20 Nov 2003 02:50:24 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 44641 invoked by uid 500); 20 Nov 2003 02:50:23 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 44624 invoked from network); 20 Nov 2003 02:50:23 -0000 Received: from unknown (HELO cn-sfo1-mail-relay1.cnet.cnwk) (206.16.5.38) by daedalus.apache.org with SMTP; 20 Nov 2003 02:50:23 -0000 Received: from holsman.net ([10.16.102.52]) by cn-sfo1-mail-relay1.cnet.cnwk (8.12.10/8.12.10) with ESMTP id hAK2oU35005312 for ; Wed, 19 Nov 2003 18:50:31 -0800 (PST) X-Spam-Filter: check_local@cn-sfo1-mail-relay1.cnet.cnwk by digitalanswers.org Message-ID: <3FBC2BF4.2040901@holsman.net> Date: Thu, 20 Nov 2003 13:50:28 +1100 From: Ian Holsman User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.6b) Gecko/20031111 Thunderbird/0.4a X-Accept-Language: en-us, en MIME-Version: 1.0 To: dev@httpd.apache.org Subject: [Fwd: cvs commit: httpd-test/specweb99/specweb99-2.0 mod_specweb99.c] Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N this commit reminds me.. weren't we going to do something similiar to this in 2.1 for the default file handler? (replace the 'stat' with a 'fstat') Will .. do you remember the whole details? it was something about putting the handle into the request_rec or something -------- Original Message -------- Subject: cvs commit: httpd-test/specweb99/specweb99-2.0 mod_specweb99.c Date: 19 Nov 2003 20:55:58 -0000 From: gregames@apache.org Reply-To: test-dev@httpd.apache.org Organization: Holsman.NET Newsgroups: server.http.apache.testing.cvs gregames 2003/11/19 12:55:58 Modified: specweb99/specweb99-2.0 mod_specweb99.c Log: customadscan: use apr_file_info_get (a.k.a fstat) rather than apr_stat for about a 7% improvement in conforming connections. The box is an aging RS/6000 with a single 375 MHz ppc604e, .5G of RAM, AIX 5.2 Revision Changes Path 1.30 +3 -3 httpd-test/specweb99/specweb99-2.0/mod_specweb99.c Index: mod_specweb99.c =================================================================== RCS file: /home/cvs/httpd-test/specweb99/specweb99-2.0/mod_specweb99.c,v retrieving revision 1.29 retrieving revision 1.30 diff -u -d -b -u -r1.29 -r1.30 --- mod_specweb99.c 7 Aug 2003 21:21:57 -0000 1.29 +++ mod_specweb99.c 19 Nov 2003 20:55:58 -0000 1.30 @@ -882,11 +882,11 @@ X = apr_psprintf(r->pool, "%1d", (adid % 36) / 9); Y = apr_psprintf(r->pool, "%1d", adid % 9); - if ((rv = apr_stat(&s, fname, APR_FINFO_SIZE, r->pool)) != APR_SUCCESS) - return; - rv = apr_file_open(&f, fname, APR_READ, APR_OS_DEFAULT, r->pool); if (rv != APR_SUCCESS) + return; + + if ((rv = apr_file_info_get(&s, APR_FINFO_SIZE, f)) != APR_SUCCESS) return; len = s.size;