httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cliff Woolley <jwool...@virginia.edu>
Subject Re: [PATCH] HTTP_VERSION macro
Date Mon, 03 Nov 2003 21:36:28 GMT
On Mon, 3 Nov 2003, William A. Rowe, Jr. wrote:

> >Well, there is also diferent define in the wininet.h with the same name.
> >Can we rename that define to AP_HTTP_VERSION like in the apache 1.3.x?
>
> Others will when you break their modules.  Your code will have to #undef
> that symbol depending on what meaning you are looking for (frankly, it's
> irritating that this symbol would be defined at all in common headers.)
> However, this *is* our bad, and please commit the appropriate fix right
> away to cvs HEAD before we go any further with 2.1!

For the record, it's HTTP_VERSION in 1.3.x also as far as I can tell.  I
agree with Bill that this isn't something we can fix in 1.3.x or 2.0.x
since it would require a major mmn bump.

--Cliff


root@deepthought:/root/apache/apache-1.3/src/include# grep VERSION *.h
ap_mmn.h: * 19980304 (1.3b6-dev)        - abstraction of SERVER_BUILT and SERVER_VERSION
ap_mmn.h: *                       discontinuation of -DSERVER_SUBVERSION support
httpd.h:#define HTTP_VERSION(major,minor) (1000*(major)+(minor))
httpd.h:#define HTTP_VERSION_MAJOR(number) ((number)/1000)
httpd.h:#define HTTP_VERSION_MINOR(number) ((number)%1000)
httpd.h:#define SERVER_BASEVERSION  SERVER_BASEPRODUCT "/" SERVER_BASEREVISION
httpd.h:#define SERVER_VERSION  SERVER_PRODUCT "/" SERVER_REVISION
httpd.h:#define HTTP_VERSION_NOT_SUPPORTED         505

root@deepthought:/root/apache/httpd-2.0/include# grep VERSION *.h
ap_config_auto.h:#define PACKAGE_VERSION ""
ap_release.h:#define AP_SERVER_MAJORVERSION "2"
ap_release.h:#define AP_SERVER_MINORVERSION "0"
ap_release.h:#define AP_SERVER_MINORREVISION AP_SERVER_MAJORVERSION "." AP_SERVER_MINORVERSION
ap_release.h:#define AP_SERVER_BASEVERSION AP_SERVER_BASEPRODUCT "/" AP_SERVER_BASEREVISION
ap_release.h:#define AP_SERVER_VERSION  AP_SERVER_BASEVERSION
httpd.h:#define HTTP_VERSION(major,minor) (1000*(major)+(minor))
httpd.h:#define HTTP_VERSION_MAJOR(number) ((number)/1000)
httpd.h:#define HTTP_VERSION_MINOR(number) ((number)%1000)
httpd.h:#define HTTP_VERSION_NOT_SUPPORTED         505
httpd.h:#define M_VERSION_CONTROL       15      /* RFC 3253: WebDAV Versioning */


Mime
View raw message