httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul J. Reder" <rede...@remulak.net>
Subject Re: cvs commit: httpd-2.0/modules/metadata mod_expires.c
Date Sat, 22 Nov 2003 01:44:19 GMT
Ooops, I didn't see the second one and the first was similar to the one
I came up with to resolve PR 24459. Sure, I'll change it to the second
solution. I agree that it is a better solution.

André Malo wrote:
> * rederpj@apache.org wrote:
> 
> 
>>  Index: mod_expires.c
>>  ===================================================================
>>  RCS file: /home/cvs/httpd-2.0/modules/metadata/mod_expires.c,v
>>  retrieving revision 1.46
>>  retrieving revision 1.47
>>  diff -u -r1.46 -r1.47
>>  --- mod_expires.c	2 Jun 2003 13:14:44 -0000	1.46
>>  +++ mod_expires.c	21 Nov 2003 23:37:05 -0000	1.47
>>  @@ -548,7 +548,8 @@
>>                   expiry = conf->expiresdefault;
>>               }
>>           }
>>  -        if (expiry != NULL) {
>>  +        /* != '\0' covers the case where ExpiresDefault is not user
>>  defined. */+        if (expiry != NULL && expiry[0] != '\0') {
>>               set_expiration_fields(r, expiry, t);
>>           }
>>       }
> 
> 
> Ah, would you mind to use the other patch provided in the PR? IMHO the other
> one addresses more the problem than the symptom.
> 
> nd
> 
> 

-- 
Paul J. Reder
-----------------------------------------------------------
"The strength of the Constitution lies entirely in the determination of each
citizen to defend it.  Only if every single citizen feels duty bound to do
his share in this defense are the constitutional rights secure."
-- Albert Einstein



Mime
View raw message