httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@attglobal.net>
Subject Re: piped log files
Date Sat, 01 Nov 2003 15:17:18 GMT
Bastiaan van der Put wrote:

> Piped log files still dont work with apache 2.0.48
> 
> piped log program '/usr/local/apache2/bin/logresolve >> 
> /home/accounts/x/xxxxxxxx/logs/access_log' failed unexpectedly
> 
> So i am using a script as suggested before , called it apacheresolve :
> 
> #!/bin/sh
> exec /usr/local/apache2/bin/logresolve >>/tmp/lr.out

I still have this patch in my tree for this feature.  ISTR wondering what other 
people thought about it, and forgetting about the issue until you just brought 
it up again.  Any concerns out there?

Index: server/log.c
===================================================================
RCS file: /home/cvs/httpd-2.0/server/log.c,v
retrieving revision 1.135
diff -u -r1.135 log.c
--- server/log.c        14 Jul 2003 14:48:40 -0000      1.135
+++ server/log.c        1 Nov 2003 15:13:35 -0000
@@ -743,6 +743,8 @@
      apr_status_t status;

      if (((status = apr_procattr_create(&procattr, pl->p)) != APR_SUCCESS) ||
+        ((status = apr_procattr_cmdtype_set(procattr, APR_SHELLCMD))
+         != APR_SUCCESS) ||
          ((status = apr_procattr_child_in_set(procattr,
                                               ap_piped_log_read_fd(pl),
                                               ap_piped_log_write_fd(pl)))

Any comments from the audience?

> When stopping apache I also get :
> 
> piped log program '/usr/local/apache2/bin/apacheresolve >> 
> /home/accounts/x/xxxxx/logs/access_log' failed unexpectedly

There is a PR for this issue.  It is perhaps timing related, as it does not 
affect everybody.


Mime
View raw message