httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Colm MacCarthaigh <c...@stdlib.net>
Subject Fallback server hostname
Date Mon, 17 Nov 2003 09:23:58 GMT

Having a fallback servername of 127.0.0.1 is broken, I realise even
in IPv4 it's not a globally reachable address, but in IPv6 it's
just plain confusing and leads to a lot (well o.k. 3 ever) of reports
that Apache isnt working for someone in IPv6.

Index: server/util.c
===================================================================
RCS file: /home/cvspublic/httpd-2.0/server/util.c,v
retrieving revision 1.142
diff -u -r1.142 util.c
--- server/util.c	3 Sep 2003 19:27:09 -0000	1.142
+++ server/util.c	17 Nov 2003 09:17:28 -0000
@@ -1987,7 +1987,7 @@
     }
 
     if (!server_hostname) 
-        server_hostname = apr_pstrdup(a, "127.0.0.1");
+        server_hostname = apr_pstrdup(a, "::1");
 
     ap_log_perror(APLOG_MARK, APLOG_ALERT|APLOG_STARTUP, 0, a,
                  "%s: Could not determine the server's fully qualified "


O.k., so that's a bit cheeky. But would "localhost" be o.k ? Or 
"unconfigured". Or make it a hard error, and have no fallback.

-- 
Colm MacCárthaigh                        Public Key: colm+pgp@stdlib.net

Mime
View raw message