httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Glenn <gs-apache-...@gluelogic.com>
Subject Re: [PATCH] ErrorLogsWithVhost for Apache 1.3.28
Date Fri, 07 Nov 2003 23:06:10 GMT
[REPOST]

On Mon, Oct 13, 2003 at 02:52:33PM -0700, Roy T. Fielding wrote:
> >On Tue, Jul 08, 2003 at 12:41:09AM -0400, Glenn wrote:
> >>Comments appreciated on the method(s) that would most likely get this
> >>accepted into 1.3.28 or 1.3.29.  (global flag, server_rec addition,
> >>other ...)  Thanks!
> 
> In general, it would require a great deal of value added to justify
> a new feature in 1.3.  I don't see that here.  It certainly doesn't
> justify a change to server_rec (even an append is a risky change).
> A global flag is possible, but a compile-time ifdef would be sufficient
> for 1.3.

Thank you very much for the explanation.

My original patch used a global and can be found at:

http://www.mail-archive.com/dev@httpd.apache.org/msg16898.html


Here's one that uses a #define:

diff -ru apache_1.3.28/src/main/http_log.c apache_1.3.28.new/src/main/http_log.c
--- apache_1.3.28/src/main/http_log.c	2003-02-03 12:13:21.000000000 -0500
+++ apache_1.3.28.new/src/main/http_log.c	2003-10-13 19:27:47.000000000 -0400
@@ -388,8 +388,14 @@
 	 * quad is the most secure, which is why I'm implementing it
 	 * first. -djg
 	 */
+#ifdef ERRORLOGS_WITH_VHOST
+	len += ap_snprintf(errstr + len, sizeof(errstr) - len,
+		"[client %s] [%s:%d] ", r->connection->remote_ip,
+		r->server->server_hostname, r->server->port);
+#else
 	len += ap_snprintf(errstr + len, sizeof(errstr) - len,
 		"[client %s] ", r->connection->remote_ip);
+#endif
     }
     if (!(level & APLOG_NOERRNO)
 	&& (save_errno != 0)


I prefer having the ability in a directive because I am not always 
permitted to recompile Apache with the #define on systems that are
kept "distribution conformist".

Thank you for your consideration.
Glenn

Mime
View raw message