httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From André Malo ...@perlig.de>
Subject Re: cvs commit: httpd-2.0/modules/filters mod_include.c
Date Thu, 23 Oct 2003 20:16:57 GMT
* nd@apache.org wrote:

>   Log:
>   fix segfault which occured if the filename was not
>   set, for example, when processing some error conditions.

>   -    if ((t = strrchr(r->filename, '/'))) {
>   +    if (r->filename && (t = strrchr(r->filename, '/'))) {
>            apr_table_setn(e, "DOCUMENT_NAME", ++t);
>        }

In fact, r->filename is used way more often within the includes filter (in
error messages). Should we catch these cases as well, i.e. replace occurences
of r->filename with r->filename ? r->filename : "<NULL>"?

nd

Mime
View raw message