Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 3607 invoked from network); 12 Sep 2003 12:31:03 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 12 Sep 2003 12:31:03 -0000 Received: (qmail 92628 invoked by uid 500); 12 Sep 2003 12:30:53 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 92581 invoked by uid 500); 12 Sep 2003 12:30:53 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 92561 invoked from network); 12 Sep 2003 12:30:52 -0000 Received: from unknown (HELO localhost.localdomain) (196.30.143.210) by daedalus.apache.org with SMTP; 12 Sep 2003 12:30:52 -0000 Received: from sharp.fm (localhost.localdomain [127.0.0.1]) by localhost.localdomain (8.11.6/8.11.6) with ESMTP id h8CCUoJ10135 for ; Fri, 12 Sep 2003 14:30:51 +0200 Message-ID: <3F61BC7A.9040300@sharp.fm> Date: Fri, 12 Sep 2003 14:30:50 +0200 From: Graham Leggett User-Agent: Mozilla/5.0 (X11; U; Linux ppc; en-US; rv:1.4) Gecko/20030712 X-Accept-Language: en-gb, en-za, en MIME-Version: 1.0 To: dev@httpd.apache.org Subject: Re: [PATCH] Bug #18756: fix many problems about ldap cache using shared memory References: <1063368100.2277.25.camel@matthieu-dev> In-Reply-To: <1063368100.2277.25.camel@matthieu-dev> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Matthieu Estrade wrote: > 1) i moved all this global declaration inside the module config, then i > made all rmm_alloc and rmm_free use these module config data. > > 2) i moved the shm init in post_config hook, then did some code to merge > all these rmm and shm addr in all vhost module config > > 3) i created a directive LDAPSharedCacheFile receiving a filename, to > create the file with apr_root_relative which will be used to create the > shm. +1 from me - I'll commit to 2.1 in the next few days assuming there are no objections? Regards, Graham -- ----------------------------------------- minfrin@sharp.fm "There's a moon over Bourbon Street tonight..."