httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brad Nicholes" <BNICHO...@novell.com>
Subject Re: cvs commit: apache-1.3/src/main rfc1413.c
Date Tue, 16 Sep 2003 21:54:12 GMT
  Looking through the code I don't see anything that would be a thread-safety issue.  What
am I missing?

Brad

Brad Nicholes
Senior Software Engineer
Novell, Inc., the leading provider of Net business solutions
http://www.novell.com 

>>> wrowe@apache.org Tuesday, September 16, 2003 2:38:16 PM >>>
Didn't you just introduce thread-safety issues?

IIRC ident wasn't thread safe.

Bill

At 03:28 PM 9/16/2003, bnicholes@apache.org wrote:
>bnicholes    2003/09/16 13:28:12
>
>  Modified:    src/main rfc1413.c
>  Log:
>  Enable rfc1413 ident functionality on NetWare.  Win32 may also need to
>  include these #defines
>  
>  Submitted by: G√ľnter Knauf <gk@gknw.de>
>  
>  Revision  Changes    Path
>  1.42      +6 -0      apache-1.3/src/main/rfc1413.c
>  
>  Index: rfc1413.c
>  ===================================================================
>  RCS file: /home/cvs/apache-1.3/src/main/rfc1413.c,v
>  retrieving revision 1.41
>  retrieving revision 1.42
>  diff -u -r1.41 -r1.42
>  --- rfc1413.c 3 Feb 2003 17:13:23 -0000       1.41
>  +++ rfc1413.c 16 Sep 2003 20:28:12 -0000      1.42
>  @@ -83,6 +83,12 @@
>   #include "rfc1413.h"
>   #include "http_main.h"               /* set_callback_and_alarm */
>   
>  +/* XXX WIN32 may also need to include these #defines */
>  +#if (defined(NETWARE) /*|| defined(WIN32)*/)
>  +#define write(a,b,c) send(a,b,c,0)
>  +#define read(a,b,c) recv(a,b,c,0)
>  +#endif /* NETWARE || WIN32 */
>  +
>   /* Local stuff. */
>   /* Semi-well-known port */
>   #define      RFC1413_PORT    113
>  
>  
>  



Mime
View raw message