Return-Path: Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 69298 invoked by uid 500); 6 Aug 2003 19:02:20 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 69285 invoked from network); 6 Aug 2003 19:02:20 -0000 Date: Wed, 6 Aug 2003 15:02:21 -0400 (EDT) From: Cliff Woolley X-X-Sender: jcw5q@cobra.cs.Virginia.EDU To: dev@httpd.apache.org Subject: Re: cvs commit: httpd-2.0/modules/dav/main mod_dav.c In-Reply-To: <20030806144648.50859.qmail@minotaur.apache.org> Message-ID: References: <20030806144648.50859.qmail@minotaur.apache.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N On Wed, 6 Aug 2003 nd@apache.org wrote: > + bb = apr_brigade_create(r->pool, r->connection->bucket_alloc); > + > + if (!bb) { > + err = dav_new_error(r->pool, HTTP_INTERNAL_SERVER_ERROR, 0, > + "Could not create bucket brigade"); > + } > + else { Nit: apr_brigade_create() will never return NULL, so you don't need to check for it. --Cliff APU_DECLARE(apr_bucket_brigade *) apr_brigade_create(apr_pool_t *p, apr_bucket_alloc_t *list) { apr_bucket_brigade *b; b = apr_palloc(p, sizeof(*b)); b->p = p; b->bucket_alloc = list; APR_RING_INIT(&b->list, apr_bucket, link); apr_pool_cleanup_register(b->p, b, brigade_cleanup, apr_pool_cleanup_null); return b; }