Return-Path: Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 33238 invoked by uid 500); 20 Aug 2003 13:28:39 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 33108 invoked from network); 20 Aug 2003 13:28:33 -0000 X-Authentication-Warning: onyx.ispol.com: grisha owned process doing -bs Date: Wed, 20 Aug 2003 09:03:30 -0400 (EDT) From: "Gregory (Grisha) Trubetskoy" X-X-Sender: grisha@onyx.ispol.com To: Jeff Trawick cc: dev@httpd.apache.org Subject: Re: [PATCH] mod_rewrite RewriteLock permissions fix In-Reply-To: <3F435148.6070900@attglobal.net> Message-ID: <20030820090004.F48820@onyx.ispol.com> References: <20030818180447.X990-100000@fenris.webthing.com> <009901c3662a$fc3c5da0$6548a8c0@addsoft.fr> <20030819105650.E29952@onyx.ispol.com> <3F4281BD.8030103@attglobal.net> <20030819180751.C40784@onyx.ispol.com> <3F435148.6070900@attglobal.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N On Wed, 20 Aug 2003, Jeff Trawick wrote: > The issues with your patch are: > > . your patch does the chown() for more than just flock()-ed files > > . there is a better place to put the non-portable flock() code, both to > keep it out of mod_rewrite and to help solve the problem for any other > modules > I agree - my patch was just a copycat from something similar done in mod_ssl - I'm guessing the code i was copying from was probably removed by the patch you mentioned. Grisha