httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gregory (Grisha) Trubetskoy" <gri...@apache.org>
Subject Re: [PATCH] mod_rewrite RewriteLock permissions fix
Date Wed, 20 Aug 2003 13:03:30 GMT

On Wed, 20 Aug 2003, Jeff Trawick wrote:

> The issues with your patch are:
>
> . your patch does the chown() for more than just flock()-ed files
>
> . there is a better place to put the non-portable flock() code, both to
> keep it out of mod_rewrite and to help solve the problem for any other
> modules
>

I agree - my patch was just a copycat from something similar done in
mod_ssl - I'm guessing the code i was copying from was probably removed by
the patch you mentioned.

Grisha

Mime
View raw message