httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From André Malo ...@perlig.de>
Subject Re: cvs commit: httpd-2.0/modules/mappers mod_rewrite.c
Date Mon, 14 Jul 2003 21:38:35 GMT
Sorry for being so harassing with this ... ;-)

* rederpj@apache.org wrote:

>   Index: mod_rewrite.c
>   ===================================================================
...
>   +    if (!(saved_rulestatus =
>   apr_table_get(r->notes,"already_rewritten"))) {

Some kind of namespace protection would be probably useful
("mod_rewrite_already_rewritten" or something).

And I think, bigger diffs or not - indentations are cool ;-)

Otherwise +1.

nd

Mime
View raw message