httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From André Malo>
Subject Re: Two mod_include problems
Date Thu, 10 Jul 2003 14:16:50 GMT
* Paul J. Reder wrote:

> The "ctx->bytes_parsed = 0;" *should* be inside the if block.
> bytes_parsed should only be reset to 0 if the parsed bytes are
> passed on (via ap_pass_brigade()). bytes_parsed is supposed to
> indicate the number of bytes in the currently held brigade
> which have been parsed. If it exceeds BYTE_COUNT_THRESHOLD then
> we forward the initial part of the brigade. This is to keep from
> buffering up huge chunks of data.

Just to clarify, one could write the patch as:

if (!empty) {
else {

The else branch means if (empty), so it would (not) be valid to reset? Why?
I bet, I'm just a missing a brigade somewhere :)


View raw message