httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bill Stoddard <b...@wstoddard.com>
Subject Re: cvs commit: httpd-2.0/support ab.c
Date Tue, 29 Jul 2003 21:26:12 GMT
Jeff Trawick wrote:

> trawick@apache.org wrote:
> 
>> trawick     2003/07/29 11:25:15
>>
>>   Modified:    .        CHANGES
>>                support  ab.c
>>   Log:
>>   ab: Work over non-loopback on Unix again.
>>     (Broken as of 2.0.47 due to dependence on an APR bug which was fixed
>>   in 2.0.47.)
>>     PR:   21495
> 
> 
>   --- ab.c    21 Jul 2003 11:41:01 -0000    1.127
> 
>>   +++ ab.c    29 Jul 2003 18:25:15 -0000    1.128
>>   @@ -1268,7 +1268,7 @@
>>            c->state = STATE_CONNECTING;
>>            c->rwrite = 0;
>>                new_pollfd.desc_type = APR_POLL_SOCKET;
>>   -            new_pollfd.reqevents = APR_POLLIN;
>>   +            new_pollfd.reqevents = APR_POLLOUT | APR_POLLIN;
>>                new_pollfd.desc.s = c->aprsock;
>>                new_pollfd.client_data = c;
>>            apr_pollset_add(readbits, &new_pollfd);
> 
> 
> This isn't something I'm particularly happy with.  It seems to work with 
> non-SSL.  If somebody (perhaps myself) can verify that it works on Win32 
> then I think it should be backported to APACHE_2_0_BRANCH prior to 
> 2.0.48, as it is an ugly 2.0.47 regression.

Quick smoke test on Windows looks good.

Bill



Mime
View raw message