httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Estrade Matthieu <estrad...@ifrance.com>
Subject Re: [PATCH] util_ldap_cache shm broken in apache 2.x
Date Wed, 02 Jul 2003 15:39:33 GMT
Hi joe,

First, thanks for the answer.

I based my code on two examples:
First the broken util_ldap_cache_mgr.c and i just changed util_ldap_rmm 
by st->util_ldap_rmm.
Then on ssl_scache_shmht.c uring rmm to see if i have to check what 
return apr_rmm_malloc and calloc. (it's not done)

After this, i decided to not check it directly in my util_ald_alloc 
because of the example.

Matthieu

Joe Orton wrote:

>On Tue, Jul 01, 2003 at 03:01:43PM +0200, Estrade Matthieu wrote:
>...
>  
>
>> #if APR_HAS_SHARED_MEMORY
>>-    if (util_ldap_shm) {
>>-        return (void *)apr_rmm_addr_get(util_ldap_rmm, apr_rmm_calloc(util_ldap_rmm,
size));
>>+    if (st->util_ldap_shm) {
>>+        return (void *)apr_rmm_addr_get(st->util_ldap_rmm, apr_rmm_calloc(st->util_ldap_rmm,
size));
>>     } else {
>>    
>>
>
>Hi Matthieu - this will still break when the shmem segment fills up, the
>code needs to check for apr_rmm_malloc/calloc returning 0.
>
>joe
>_____________________________________________________________________
>Envie de discuter en "live" avec vos amis ? Télécharger MSN Messenger
>http://www.ifrance.com/_reloc/m la 1ère messagerie instantanée de France
>
>  
>


_____________________________________________________________________
Envie de discuter en "live" avec vos amis ? Télécharger MSN Messenger
http://www.ifrance.com/_reloc/m la 1ère messagerie instantanée de France


Mime
View raw message