httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thom May <thom...@apache.org>
Subject Re: [PATCH][1.3] Segfault in mod_proxy
Date Thu, 17 Jul 2003 14:35:57 GMT
* Jeff Trawick (trawick@attglobal.net) wrote :
> Thom May wrote:
> 
> >--- build-tree/apache_1.3.27/src/modules/proxy/proxy_ftp.c	2002-04-07 
> >20:57:36.000000000 +0200
> >+++ build-tree/apache_1.3.27/src/modules/proxy/proxy_ftp.c	2003-07-17 
> >12:12:34.000000000 +0200
> ...
> >+#ifdef EAPI
> >+    ap_hook_use("ap::mod_proxy::ftp::handler::set_destport", 
> >+                AP_HOOK_SIG2(int,ptr), 
> >+                AP_HOOK_TOPMOST,
> >+                &destport, r);
> >+#endif /* EAPI */
> 
> no "ifdef EAPI" stuff should be present in real Apache for various reasons
> 
> (I figure you were going to yank this before committing, but just in 
> case...)
> 
yes, i was. I should've pulled it before posting, but didn't want to go
messing around hand editting diffs :-)
it's gone from the patch I've applied to my source tree.
Cheers for the review!
-Thom

Mime
View raw message