httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: [PATCH] util_ldap_cache shm broken in apache 2.x
Date Wed, 02 Jul 2003 12:23:57 GMT
On Tue, Jul 01, 2003 at 03:01:43PM +0200, Estrade Matthieu wrote:
...
>  #if APR_HAS_SHARED_MEMORY
> -    if (util_ldap_shm) {
> -        return (void *)apr_rmm_addr_get(util_ldap_rmm, apr_rmm_calloc(util_ldap_rmm,
size));
> +    if (st->util_ldap_shm) {
> +        return (void *)apr_rmm_addr_get(st->util_ldap_rmm, apr_rmm_calloc(st->util_ldap_rmm,
size));
>      } else {

Hi Matthieu - this will still break when the shmem segment fills up, the
code needs to check for apr_rmm_malloc/calloc returning 0.

joe

Mime
View raw message