httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: cvs commit: apr-util/include apr_buckets.h
Date Wed, 02 Jul 2003 06:37:20 GMT
On Wed, Jul 02, 2003 at 02:03:39AM -0400, Cliff Woolley wrote:
> On Wed, 2 Jul 2003 jwoolley@apache.org wrote:
> 
> > jwoolley    2003/07/01 22:25:44
> >
> >   Modified:    buckets  apr_buckets_alloc.c
> >                include  apr_buckets.h
> >   Log:
> >   an addition to the api to allow httpd mpm's to share an apr_allocator_t
> >   between a thread pool and the thread's bucket allocator.  this will allow
> >   the freelist max size to be managed.
> 
> I just realized there's a problem with this... if you call
> apr_bucket_alloc_create_ex() and pass it an allocator, alloc_cleanup()
> should not call apr_allocator_destroy(allocator)... that should be the job
> of the caller.  I'm going to have to add a flag to the apr_bucket_alloc_t
> to keep track of this.

Eh? Why the flag? What is that for... doesn't the caller know when and if he
should clean up? So there shouldn't be a need for a flag...

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message