httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From André Malo ...@perlig.de>
Subject Re: [patch] segfault in ap_internal_redirect
Date Mon, 02 Jun 2003 11:21:25 GMT
* Stas Bekman wrote:

> internal_internal_redirect() may return NULL, but this is not tested, causing
> segfault in these situations. The following patch fixes that. Notice that when
> NULL is returned ap_die has been already called, so no special action is
> required on ap_internal_redirect's part.

Yep, it was already fixed in 2.1 in conclusion with the
LimitInternalRecursion patch (hey folks, please review for backport!).

> Index: modules/http/http_request.c
> ===================================================================
> RCS file: /home/cvs/httpd-2.0/modules/http/http_request.c,v
> retrieving revision 1.152.2.4
> diff -u -r1.152.2.4 http_request.c
> --- modules/http/http_request.c 19 May 2003 15:24:05 -0000      1.152.2.4
> +++ modules/http/http_request.c 2 Jun 2003 10:27:13 -0000
> @@ -480,16 +480,19 @@
>   AP_DECLARE(void) ap_internal_redirect(const char *new_uri, request_rec *r)

This patch is not sufficient anyway, since the same must apply to
ap_internal_redirect_handler.

nd
-- 
Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook.
Ook! Ook? Ook. Ook? Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook.
Ook. Ook. Ook. Ook. Ook? Ook. Ook! Ook! Ook? Ook! Ook. Ook? Ook. Ook.
Ook. Ook. Ook. Ook. Ook! Ook. Ook! Ook! Ook! Ook!           Ook! Ook.

Mime
View raw message