httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cliff Woolley <>
Subject Re: [PATCH] Avoid unnecessary brigade splits on core input and output filters. WAS: EOS or FLUSH buckets
Date Fri, 13 Jun 2003 04:50:52 GMT
On Thu, 12 Jun 2003, Justin Erenkrantz wrote:

> What would happen if e weren't there and it were passed to
> APR_RING_SPLIT_TAIL?  -- justin

By "weren't there," I assume you mean "were in some other brigade".

Then the supposed sequence of buckets represented by
APR_BRIGADE_FIRST(ctx->b)...APR_BUCKET_PREV(e) would be broken, since if
bucket e is not in ctx->b then neither is APR_BUCKET_PREV(e).  Inserting
this into brigade b would cause b to be a broken ring, and the fixup code
would end up halfway inserting e into ctx->b.

In other words, it would be bad.  :)


View raw message