httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Collins-Sussman <suss...@collab.net>
Subject Re: [PATCH] mod_dav streamy error handling
Date Thu, 19 Jun 2003 20:17:17 GMT

gstein (and others), here is another micro-patch for the original
mod_dav.c 1.94 change we made a couple of weeks ago.  David Waite
noticed a segfault and made this patch.  Please apply ASAP!

The old code never hit this problem, because it would always send NULL
as the last argument to dav_send_multistatus(), *unless* a 404 href
response came back from the provider, in which case it sent
doc->namespaces.  But in that situation, that means doc *had* to be
non-NULL; a 404 href can only happen when PROPFIND has a body asking
for specific things.


--- mod_dav.c   3 Jun 2003 22:09:24 -0000       1.94
+++ mod_dav.c   19 Jun 2003 20:07:41 -0000
@@ -2051,3 +2051,3 @@
         badprops. */
-    dav_begin_multistatus(ctx.bb, r, HTTP_MULTI_STATUS, doc->namespaces);
+    dav_begin_multistatus(ctx.bb, r, HTTP_MULTI_STATUS, doc ? doc->namespaces : NULL);



Mime
View raw message