httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Estrade Matthieu <estrad...@ifrance.com>
Subject [PATCH] first code of a patch for util_ldap - httpd-2.0
Date Thu, 12 Jun 2003 15:23:02 GMT
Hi,

After reading util_ldap in modules/experimental, i found some broken 
stuff in the cache.
The shm was created in child init hook, and util_ldap_shm, 
util_ldap_rmm, util_ldap_cache were declared as global in util_ldap_cache.h.
I tryied to make it running with worker mpm and it was very unstable.

I tryied to do a patch.
I moved the shm creation in post_config hook, with a file 
logs/ldap_cache_pid_server instead of /tmp/mod_ldap_cache.
Then, i created inside include/util_ldap.h, in the module conf 
(util_ldap_state_t) 3 new var: util_ldap_shm, util_ldap_rmm, and 
ldap_cache which were global before.
To finish, i patched all function in util_ldap.c util_ldap_cache.c and 
util_ldap_cache_mgr.c to make them receiving this module conf instead of 
using the global var.

I post the patch i did, which is still dirty and with special comments. 
i will continue working on it to be sure it's stable and to clean it.
I still have to patch the shm init twice because of post_config launched 
twice.
i am open to other way to patch the problem and to modify my code.

Why util_ldap.h is in include/ and util_ldap.c is in modules/experimental ?

regards,

Matthieu Estrade


Mime
View raw message