httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Glenn <gs-apache-...@gluelogic.com>
Subject Re: [PATCH] ErrorLogsWithVhost for Apache 1.3.28
Date Thu, 26 Jun 2003 15:18:41 GMT
On Thu, Jun 26, 2003 at 09:01:21AM +0200, Astrid Ke?ler wrote:
> > On Thu, Jun 26, 2003 at 12:04:31AM +0200, Astrid Ke?ler wrote:
> >> > This adds a directive ErrorLogsWithVhost that extends the error log format
> >> > by adding server name and port to entries in the error logs.
> >>
> >> This can also be done with LogFormat using %v and %p. What is
> >> wrong with these log formats?
> 
> > "LogFormat" works well with "CustomLog" and "TransferLog" in mod_log_config,
> > but "ErrorLog" is in the core and does not support "LogFormat".
> 
> You are right. My fault, I didn't read carefully enough. As Joshua I'm
> +1 for the concept. But I'm not sure if we need a separate directive.
> What about a second parameter to ErrorLog?

That's an interesting idea.
I can change ErrorLog to a TAKE12 to take an optional parameter so as not
to break existing configs.  Is this method preferred to a second directive?

I am not suggesting supporting everything in LogFormat; only a few key
words.  Initially, there would only be two key words for error log format,
default and withvhost, or something like that.

I'd still rather set a global variable for withvhosts than to extend any
existing structures, but would like to know if there are other cleaner
methods.

Thanks.
Glenn

Mime
View raw message