Return-Path: 
 <dev-return-37804-apmail-httpd-dev-archive=httpd.apache.org@httpd.apache.org>
Delivered-To: apmail-httpd-dev-archive@httpd.apache.org
Received: (qmail 13287 invoked by uid 500); 19 May 2003 15:32:31 -0000
Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
list-help: <mailto:dev-help@httpd.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@httpd.apache.org>
list-post: <mailto:dev@httpd.apache.org>
Delivered-To: mailing list dev@httpd.apache.org
Received: (qmail 13208 invoked from network); 19 May 2003 15:32:30 -0000
Date: Mon, 19 May 2003 11:31:57 -0400
From: Geoff Thorpe <geoff@geoffthorpe.net>
Subject: Re: cvs commit: httpd-2.0/modules/ssl ...
In-reply-to: <20030519144847.69490.qmail@icarus.apache.org>
To: dev@httpd.apache.org
Cc: wrowe@apache.org
Message-id: <200305191131.57473.geoff@geoffthorpe.net>
MIME-version: 1.0
Content-type: text/plain; charset=iso-8859-1
Content-transfer-encoding: 7BIT
Content-disposition: inline
User-Agent: KMail/1.5
References: <20030519144847.69490.qmail@icarus.apache.org>
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N

Hi there,

This and the previous commit caught my attention;

On May 19, 2003 10:48 am, wrowe@apache.org wrote:
> wrowe       2003/05/19 07:48:47
>
>   Modified:    modules/ssl config.m4 mod_ssl.c mod_ssl.h
>                         ssl_engine_config.c ssl_engine_init.c
>                         ssl_toolkit_compat.h
>   Log:
>     Roll away the SSL_EXPERIMENTAL_ENGINE test in favor of testing for
> the ENGINE_init() function in config.m4, and rely on HAVE_ENGINE_INIT
> instead.
>
>   Reviewed by: Ben Laurie (concept)
>
>   Revision  Changes    Path
>   1.14      +1 -0      httpd-2.0/modules/ssl/config.m4
>
>   Index: config.m4
>   ===================================================================
>   RCS file: /home/cvs/httpd-2.0/modules/ssl/config.m4,v
>   retrieving revision 1.13
>   retrieving revision 1.14
>   diff -u -r1.13 -r1.14
>   --- config.m4	19 May 2003 14:43:20 -0000	1.13
>   +++ config.m4	19 May 2003 14:48:47 -0000	1.14
>   @@ -79,6 +79,7 @@
>        APACHE_CHECK_SSL_TOOLKIT
>        AC_CHECK_FUNCS(SSL_set_state)
>        AC_CHECK_FUNCS(SSL_set_cert_store)
>   +    AC_CHECK_FUNCS(ENGINE_init)
>    ])
>
>    dnl #  end of module specific part

The AC_CHECK_FUNCS stuff is not really useful here because of the 
overhauls made in acinclude.h (which was why they were removed in the 
first place). They actually risk to fail unnecessarily because of the 
issues with dependencies on apr - see the APACHE_CHECK_SSL_TOOLKIT 
implementation. I'd suggest that the ENGIEN test be inserted into 
APACHE_CHECK_SSL_TOOLKIT macro, and it would probably make more sense to 
test for the openssl/engine.h header rather than the ENGINE_init() 
function (eg. future versions might redefine ENGINE_init as a 
backwards-compatibility macro rather than an actual function, but that 
would fail the current autoconf test). As for APACHE_CHECK_SSL_TOOLKIT, 
I'm glancing at viewcvs as I type this and I'd suggest putting the test 
somewhere in the openssl-part of the section marked "dnl Run header and 
version checks", just before the version check. Eg. (this is not diff -u, 
it's me improvising and avoiding line-breaks ...);

<untested>
    ....
    AC_CHECK_HEADERS([openssl/opensslv.h openssl/ssl.h],....
    if test "x$ap_ssltk_type" = "x"; then
      AC_MSG_ERROR([No SSL/TLS headers were available])
    fi
    dnl so it's OpenSSL - report, then test for a good version
    echo "... SSL/TLS support configuring for OpenSSL"
+   AC_CHECK_HEADERS([openssl/engine.h],
+       [AC_DEFINE(HAVE_ENGINE)], [])
    AC_MSG_CHECKING(for OpenSSL version)
    AC_TRY_COMPILE([#include <openssl/opensslv.h>]
    ....
</untested>

Cheers,
Geoff

-- 
Geoff Thorpe
geoff@geoffthorpe.net
http://www.geoffthorpe.net/