httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rich Bowen <rbo...@rcbowen.com>
Subject Re: 403's not getting logged?
Date Sun, 11 May 2003 00:28:04 GMT
On Fri, 9 May 2003, Joshua Slive wrote:

> OK.  Here is a tested patch, but I'll wait for a couple explicit +1s
> before committing.

+1

> I'm not sure if perhaps the message should say "... because search
> permissions (chmod +x) are missing ..."  to help newbies.

That would not only help the newbies, it would help the "tech support"
people who are faced with the beligerent newbies who insist that the
directory does not need to be +x because nothing is being executed. Yes,
I know, they are being silly, but having supporting evidence in the
error message would save a few pointless arguments on IRC, if nothing
else.

I like verbose error messages, particularly those that nudge the user
towards the solution.

> Index: http_request.c
> ===================================================================
> RCS file: /home/cvs/apache-1.3/src/main/http_request.c,v
> retrieving revision 1.168
> diff -u -d -b -u -r1.168 http_request.c
> --- http_request.c      3 Feb 2003 17:13:23 -0000       1.168
> +++ http_request.c      9 May 2003 20:27:32 -0000
> @@ -288,7 +288,12 @@
>          }
>          else {
>  #if defined(EACCES)
> -            if (errno != EACCES)
> +            if (errno == EACCES)
> +                ap_log_rerror(APLOG_MARK, APLOG_ERR, r,
> +                            "access to %s failed because search "
> +                            "permissions are missing on a component "
> +                            "of the path", r->uri);
> +            else
>  #endif
>                  ap_log_rerror(APLOG_MARK, APLOG_ERR, r,
>                              "access to %s failed", r->uri);
>
>

-- 
Rich Bowen
Apache - mod_perl - Perl - CGI
http://www.ApacheAdmin.com/

Mime
View raw message