httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <>
Subject Re: PATCH - Uninitialized Variables
Date Wed, 14 May 2003 04:05:53 GMT
David Deaves wrote:
> I've submitted this patch under BugID 19242, but thought I would submit
> it here as well so it doesn't get overlooked.
> In modules/ssl/ssl_engine_io.c of Apache 2.0.45
> I traced the problem to the  'block' member of
> the 'bio_filter_in_ctx_t' structure not being
> initialized before being used.

wow, it is apr_palloc()-ed :(

> So I added initializatoins for the 'block' member
> and the 'mode' member (also not initialized but
> didn't contribute to our problem) to the
> 'ssl_io_input_add_filter' function.

patch looks very good to me, but I'm extremely unfamiliar with mod_ssl...

if nobody chimes in I'll commit it to 2.1-dev in a couple of days

View raw message