httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: [PATCH] better failure mode for >2gb logfiles
Date Thu, 22 May 2003 22:18:53 GMT
On Thu, May 22, 2003 at 01:46:26PM -0700, Ian Holsman wrote:
> Joe Orton wrote:
> >The failure mode when write()ing past the 2gb file size limit on 
> >systems which have such a limit is that a SIGXFSZ is delivered; 
> >SIGXFSZ has an equivalent disposition to SIGSEGV on POSIX systems,
> >by default.
> >
> >This patch changes the failure mode so that the SIGXFSZ is ignored;  
> >the LFS standard requires that the write() then fails with EFBIG, so
> >this becomes equivalent to an out-of-disk-space condition: the log
> >messages are then silently dropped on the floor, and you don't know
> >about it, but the server keeps functioning normally otherwise.
> 
> -1 as default behavior
> I'd rather have a machine go down then for it to stop logging.

The current behaviour with prefork if the access_log passes 2gb is that
the server continues handling requests, but in "MaxRequestsPerChild 1"
mode, i.e. slowly and with very high load.  So I think this change is
an improvement.

> Silent failure is never a good thing.

It does appear that mod_log_config ignores write() failures, but I'd
say that issue is orthogonal to this change.

Regards,

joe

Mime
View raw message