Return-Path: Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 15526 invoked by uid 500); 19 Apr 2003 00:06:13 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 15513 invoked from network); 19 Apr 2003 00:06:12 -0000 From: =?ISO-8859-1?Q?Andr=E9?= Malo Subject: Re: cvs commit: httpd-2.0/modules/loggers mod_log_config.c MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable Organization: TIMTOWTDI References: <20030418194011.21244.qmail@icarus.apache.org> Date: Sat, 19 Apr 2003 01:59:32 +0200 To: dev@httpd.apache.org Message-ID: User-Agent: Yes! X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N Sorry for harassing again, but ... :) * trawick@apache.org wrote: > + if (!strcmp(a, "pid/tid")) { > + return apr_psprintf(r->pool, "%ld/%pT", (long)getpid(), &t= id); > + } after further thinking: We do not need the special {pid/tid} format=20 extension. If someone wants to get it, he can simply use %{pid}P/%{tid}P So I think it can be removed. > + else if (!strcmp(a, "tid")) { > + return apr_psprintf(r->pool, "%pT", &tid); > + } IIRC there are APR format strings for pids and tids (?). If so, we should= =20 use them, I'd guess. nd --=20 die (eval q-qq:Just Another Perl Hacker :-) # Andr=E9 Malo, #