httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From André Malo ...@perlig.de>
Subject Re: cvs commit: apache-1.3/src/modules/standard mod_rewrite.c
Date Thu, 03 Apr 2003 15:29:42 GMT
* Jim Jagielski wrote:

> At 9:11 PM +0000 4/2/03, nd@apache.org wrote:
>>  @@ -2067,12 +2098,12 @@
>>       splitout_queryargs(r, p->flags & RULEFLAG_QSAPPEND);
>>
>>       /*
>>  -     *   Again add the previously stripped per-directory location
>>  -     *   prefix if the new URI is not a new one for this
>>  -     *   location, i.e. if it's not starting with either a slash
>>  -     *   or a fully qualified URL scheme.
>>  +     *  Add the previously stripped per-directory location
>>  +     *  prefix if the new URI is not a new one for this
>>  +     *  location, i.e. if it's not an absolute URL (!) path nor
>>  +     *  a fully qualified URL scheme.
>>        */
>>  -    if (prefixstrip && !ap_os_is_path_absolute(r->filename)
>>  +    if (prefixstrip && *r->filename != '/'
>>  	&& !is_absolute_uri(r->filename)) {
>>           rewritelog(r, 3, "[per-dir %s] add per-dir prefix: %s -> %s%s",
>>                      perdir, r->filename, perdir, r->filename);
>>
> Is that right?? We aren't bothering to check
> !ap_os_is_path_absolute(r->filename) anymore?

At this stage: yes.

prefixstrip is only true in directory context, where you have the 
possibilities:

(1) RewriteRule foo bar
(2) RewriteRule foo /baz
(3) RewriteRule foo http://elsewhere

checking ap_os_is_path_absolute(r->filename) was totally useless, because 
it's first added when the condition (1) is true (i.e. after this check).

(That's what I meant with confusion between local paths and url paths ... 
;-)

nd
-- 
Gib' mal folgendes in die Kommandozeile ein (und einen Moment warten):

net send localhost "Buuuh!"
Na, erschreckt?                              -- Markus Becker in mpdsh

Mime
View raw message